Conversation
Added Python3 StringIO imports
There was a problem hiding this comment.
Sorry I nearly forgot about this addition. This one is a totally blind duck-punch that I added because one of my PDF files was falling through this code all the way to the exception. I havn't read the pdf spec so forgive my ignorance. My PDF worked after the change so that's all I cared about at the time. If I made a bad call and you want me to remove and rebase this, let me know.
Python 3 conversion. Undoing 3.3 fix to split commits
|
The py3-3Fix branch causes this code to fail in both 2.7 and 3.3. from PyPDF2 import PdfFileReader
pdf = PdfFileReader(open("test.pdf", "rb"))
print(pdf.getPage(0).extractText())As a side note, perhaps the bugtracker could be enabled, now that this is the officially blessed fork of pyPdf? |
|
Cross-version support does matter to us. Our current estimate is that PyPDF2 should be good with 3.3 by September--maybe sooner! |
|
a python 3.3 but that seems no-one has reported here: http://stackoverflow.com/questions/19371101/pypdf2-issues-with-pdf-encoding/19386521 |
|
Closing this since the branches were merged |
MANIFEST.in: Add docs and tests
Hi,
I ported this over to Python 3. I have tested for backwards compatibility with Python 2 and all seems well although I havn't tested it extensively so it may need some more investigation.
I chose to use importlib for 'relative' style imports. Forgive my naievity if this was a bad choice, its the first time I've run into the differences between the Python 2 and 3 module import handling.