SEC: Disallow custom XML entity declarations for XMP metadata#3724
Merged
stefan6419846 merged 1 commit intopy-pdf:mainfrom Apr 10, 2026
Merged
SEC: Disallow custom XML entity declarations for XMP metadata#3724stefan6419846 merged 1 commit intopy-pdf:mainfrom
stefan6419846 merged 1 commit intopy-pdf:mainfrom
Conversation
While *libexpat* already handled the more severe cases, it has still been possible to cause rather high memory usage. For this reason, disallow entity declarations completely. I decided against *defusedxml* for now, as I do not see the benefit of including an untyped external package for something this small, especially considering that the public maintenance status does not look very promising.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 55 55
Lines 10022 10029 +7
Branches 1842 1842
=======================================
+ Hits 9765 9772 +7
Misses 149 149
Partials 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan6419846
added a commit
that referenced
this pull request
Apr 10, 2026
## What's new ### Security (SEC) - Disallow custom XML entity declarations for XMP metadata (#3724) by @stefan6419846 ### New Features (ENH) - Skip MD5 key derivation for AES-256 encrypted PDFs (#3694) by @Ygnas ### Bug Fixes (BUG) - Use remove_orphans in compress_identical_objects (#3310) by @j-t-1 - Fix PdfReadError when xref table contains comments before trailer (#3710) by @rassie - Correctly verify AES padding during decryption (#3699) by @stefan6419846 - Fix stale object cache from non-authoritative object streams (#3698) by @astahlman - Fix extract_links pairing when annotations include non-links (#3687) by @ReinerBRO ### Documentation (DOC) - Add AI policy (#3717) by @stefan6419846 [Full Changelog](6.9.2...6.10.0)
This was referenced Apr 11, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While libexpat already handled the more severe cases, it has still been possible to cause rather high memory usage. For this reason, disallow entity declarations completely.
I decided against defusedxml for now, as I do not see the benefit of including an untyped external package for something this small, especially considering that the public maintenance status does not look very promising.