ENH: Add 'strict' parameter to PDFWriter#3503
Conversation
|
Thanks for the PR. Could you please update |
|
@stefan6419846 yeah sure, let me look into it. |
|
@stefan6419846, are there any more changes you would like me to do? |
|
For now, this is the only place I am aware where the writer would use the strict mode and indeed the reason for opening the corresponding issue. |
|
@stefan6419846 is there any specific issue with pytest on windows, as there is file not found error. Any workaround that i need to take care of in my PR? |
|
This most likely just is a temporary network error. I am going to restart the corresponding job as soon as GitHub allows me. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 56 56
Lines 9679 9681 +2
Branches 1753 1753
=======================================
+ Hits 9398 9400 +2
Misses 168 168
Partials 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@stefan6419846 now it has passed all |
## What's new ### New Features (ENH) - Add 'strict' parameter to PDFWriter (#3503) by @Arya-A-Nair ### Bug Fixes (BUG) - PdfWriter.append fails when there are articles being None (#3509) by @Noah-Houghton ### Documentation (DOC) - Execute docs examples in CI (#3507) by @ievgen-kapinos [Full Changelog](6.1.3...6.2.0)
This PR closes #3494.
This change adds a 'strict' parameter to the PDFWriter class, allowing users to enable strict mode for error handling during PDF writing operations. The parameter is added to the init method with a default value of False to maintain backward compatibility.