Skip to content

BUG: Get font information more reliably when removing text#3252

Merged
stefan6419846 merged 8 commits intopy-pdf:mainfrom
samuelbradshaw:better-font-detection
Apr 15, 2025
Merged

BUG: Get font information more reliably when removing text#3252
stefan6419846 merged 8 commits intopy-pdf:mainfrom
samuelbradshaw:better-font-detection

Conversation

@samuelbradshaw
Copy link
Contributor

Last month I contributed pull request #3216, an enhancement to PdfWriter.removeText() that allows users to remove only the specified fonts. Since then, I've come across a few PDFs where my simple logic to find fonts wasn't working. This fix walks through the PDF structure to find font references more reliably. I also added a few explanatory comments.

@codecov
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (96ba79c) to head (3353d04).
Report is 73 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3252   +/-   ##
=======================================
  Coverage   96.59%   96.60%           
=======================================
  Files          53       53           
  Lines        8957     8979   +22     
  Branches     1648     1659   +11     
=======================================
+ Hits         8652     8674   +22     
  Misses        183      183           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846 stefan6419846 merged commit 3c72462 into py-pdf:main Apr 15, 2025
16 checks passed
ash01ish pushed a commit to ash01ish/pypdf that referenced this pull request May 9, 2025
stefan6419846 added a commit that referenced this pull request May 11, 2025
## What's new

### New Features (ENH)
- Add support for IndirectObject.__iter__ (#3228) by @bryan-brancotte
- Allow filtering by font when removing text (#3216) by @samuelbradshaw

### Bug Fixes (BUG)
- Add missing named destinations being ByteStringObjects (#3282) by @stefan6419846
- Get font information more reliably when removing text (#3252) by @samuelbradshaw
- T* 2D Translation consistent with PDF 1.7 Spec (#3250) by @hackowitz-af
- Add font stack to q/Q operations in layout mode (#3225) by @hackowitz-af
- Avoid completely hiding image loading issues like exceeding image size limits (#3221) by @stefan6419846
- Using compress_identical_objects on transformed content duplicates differing content (#3197) by @danio
- Consider BlackIs1 parameter for CCITTFaxDecode filter (#3196) by @stefan6419846

### Robustness (ROB)
- Deal with insufficient cm matrix during text extraction (#3283) by @stefan6419846
- Allow merging when annotations miss D entry (#3281) by @stefan6419846
- Fix merging documents if there are no Dests (#3280) by @stefan6419846
- Fix crash on malformed action in outline (#3278) by @larsga
- Fix compression issues for removed images which might be None (#3246) by @stefan6419846
- Attempt to deal with non-rectangular FlateDecode streams (#3245) by @stefan6419846
- Handle some None values for broken PDF files (#3230) by @stefan6419846

### Developer Experience (DEV)
- Multiple style improvements by @j-t-1
- Update ruff to 0.11.0 by @stefan6419846

### Maintenance (MAINT)
- Conform ASCIIHexDecode implementation to specification (#3274) by @j-t-1
- Modify comments of filters that do not use decode_parms (#3260) by @j-t-1

### Code Style (STY)
- Simplify warnings & debugging in layout mode text extraction (#3271) by @hackowitz-af
- Standardize mypy assert statements (#3276) by @j-t-1

[Full Changelog](5.4.0...5.5.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants