ROB: ignore annotation with Go-To action missing a /D name attribute (#3211)#3213
Closed
mlorant wants to merge 1 commit intopy-pdf:mainfrom
Closed
ROB: ignore annotation with Go-To action missing a /D name attribute (#3211)#3213mlorant wants to merge 1 commit intopy-pdf:mainfrom
mlorant wants to merge 1 commit intopy-pdf:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3213 +/- ##
==========================================
- Coverage 96.53% 96.51% -0.03%
==========================================
Files 53 53
Lines 8930 8933 +3
Branches 1642 1643 +1
==========================================
+ Hits 8621 8622 +1
- Misses 186 187 +1
- Partials 123 124 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Sorry for the mess with the force-push, I'm not being used to mypy, my initial patch was not passing the code style check 😅 |
Collaborator
|
Thanks for the PR. As mentioned in the issue, this still needs a test to ensure that this will not break again in the future. By the way: No need to force push anything here - commits are always squashed on merge. |
stefan6419846
added a commit
that referenced
this pull request
May 8, 2025
Collaborator
|
Fixed properly in #3281. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug encountered in issue #3211.
I've being looking through the official Acrobat PDF standard specifications, and this
/Dfield should be present for Go-To actions, however the code already has a case where this /D is a NullObject, so I guess it is fine to consider the non-existence case similarly.