BUG: Ensure add_metadata can deal with _info = None#3040
Merged
stefan6419846 merged 2 commits intopy-pdf:mainfrom Jan 11, 2025
Merged
BUG: Ensure add_metadata can deal with _info = None#3040stefan6419846 merged 2 commits intopy-pdf:mainfrom
add_metadata can deal with _info = None#3040stefan6419846 merged 2 commits intopy-pdf:mainfrom
Conversation
The `assert isinstance` hid the information that `_info` is `Optional`, in which case `add_metadata` would raise an assertion error. Properly initialise `_info` if it's not set. Fixes py-pdf#3036
Contributor
Author
|
Looks like the 3.12 test fails because of a connection error, and windows because it attempts to access a bunch of weird looking URLs on corpora.tika.apache.org which is either down or dead. |
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3040 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 52 52
Lines 8770 8770
Branches 1595 1596 +1
=======================================
Hits 8451 8451
Misses 191 191
Partials 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Jan 11, 2025
stefan6419846
added a commit
that referenced
this pull request
Jan 26, 2025
## What's new ### Deprecations (DEP) - Deprecate with replacement CCITParameters (#3019) by @j-t-1 - Correct deprecation of interiour_color (#2947) by @j-t-1 ### New Features (ENH) - Support alternative (U)F names for embedded file retrieval (#3072) by @stefan6419846 - Adding support for reading .metadata.keywords (#2939) by @Lucas-C ### Bug Fixes (BUG) - Handle further Tf operators in text extraction layout mode (#3073) by @blushingpenguin - Ensure `add_metadata` can deal with `_info = None` (#3040) by @xmo-odoo - Handle IndirectObject in CCITTFaxDecode filter (#2965) by @stefan6419846 - Handle chained colorspace for inline images when no filter is set (#3008) by @stefan6419846 - Avoid extracting inline images twice and dropping other operators (#3002) by @stefan6419846 - Fixed reference of value with `str.__new__` in TextStringObject (#2952) by @thomas-forte - Handle indirect objects in font width calculations (#2967) by @nsw42 - Title sometimes is bytes and not str (#2930) by @reformy - Fix undefined variable for text extraction (regression) (#2934) by @stefan6419846 - Don't close stream passed to PdfWriter.write() (#2909) by @alexaryn ### Robustness (ROB) - Handle zero height fonts when extracting text (#3075) by @blushingpenguin - Deal with content streams not containing streams (#3005) by @stefan6419846 - Gracefully handle some text operators when the operands are missing (#3006) by @stefan6419846 - Fall back to non-Adobe Ascii85 format for missing end markers (#3007) by @stefan6419846 - Ignore odd-length strings when processing cmap lines (#3009) by @stefan6419846 - Skip annotation destination being NullObject in PdfWriter (#2964) by @stefan6419846 - Skip destination page being None in PdfWriter (#2963) by @dxsooo - Fix infinite loop case when reading null objects within an Array by @jakep-allenai - Fixing infinite loop in ArrayObject read_from_stream (#2928) by @jakep-allenai ### Documentation (DOC) - Add note about default line colors (#3014) by @stefan6419846 ### Developer Experience (DEV) - Remove ignoring Ruff rule PGH004 (#3071) by @j-t-1 - Tidy ignore array in tool.ruff.lint (#3069) by @j-t-1 - Move Windows CI to Python 3.13 (#3003) by @stefan6419846 - Move to Ubuntu 22.04 (#3004) by @stefan6419846 ### Maintenance (MAINT) - Fix formatting of warning message and include exception message (#3076) by @stefan6419846 - Narrow return type for `ContentStream.operations` (#2941) by @kmurphy4 ### Testing (TST) - Fix image similarity for upcoming Ubuntu 24.04 (#3039) by @stefan6419846 - Replace broken Apache Tika Corpora urls (#3041) by @stefan6419846 ### Code Style (STY) - Add form feed to WHITESPACES (#3054) by @j-t-1 - Lots of small internal changes by @j-t-1 [Full Changelog](5.1.0...5.2.0) Signed-off-by: stefan6419846 <96178532+stefan6419846@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assert isinstancehid the information that_infoisOptional, in which caseadd_metadatawould raise an assertion error.Properly initialise
_infoif it's not set.Fixes #3036