BUG: When scaling a page, reset the cropBox to match the new mediaBox#272
Closed
BrianPainter wants to merge 3 commits intopy-pdf:mainfrom
Closed
BUG: When scaling a page, reset the cropBox to match the new mediaBox#272BrianPainter wants to merge 3 commits intopy-pdf:mainfrom
BrianPainter wants to merge 3 commits intopy-pdf:mainfrom
Conversation
|
The |
Member
|
Thank you for the contribution :-) |
Member
|
Reminds me of #240 😄 |
Member
|
I'm uncertain if this is actually desirable. A unit test which shows the new behavior would be amazing 🙏 |
This was referenced Jun 28, 2022
MartinThoma
added a commit
that referenced
this pull request
Jul 6, 2022
Member
|
@BrianPainter @ggicci I've moved the logic to #1066 as PyPDF2 has changed a lot and rebasing would likely be a pain. I would appreciate if you would participate in the discussions there :-) Especially, I would like to know what you think about scaling all of the other boxes as well. |
MartinThoma
added a commit
that referenced
this pull request
Jul 6, 2022
Co-authored-by: Henri Salo <henri.salo@nixu.com> Closes #272
MartinThoma
added a commit
that referenced
this pull request
Jul 6, 2022
Closes #272 Co-authored-by: Henri Salo <henri.salo@nixu.com>
MartinThoma
added a commit
that referenced
this pull request
Jul 6, 2022
Closes #272 Co-authored-by: Brian Painter <brianpainter@tindallcorp.com>
MartinThoma
added a commit
that referenced
this pull request
Jul 9, 2022
Closes #272 Co-authored-by: Brian Painter <brianpainter@tindallcorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page is scaled, shouldn't the cropBox scale at the same rate as the mediaBox? If the cropBox is not changed, then we end up with a "zoomed in" view of the PDF page (if we were scaling to a larger size).