TST: Skip tests using fpdf2 if it's not installed#2419
Merged
MartinThoma merged 1 commit intomainfrom Jan 21, 2024
Merged
Conversation
The Debian ecosystem installs only packages which are also present
in the Debian ecosystem for testing. This includes pytest, but it
does not include fpdf2.
Adding the line 'pytest.importorskip("fpdf")' within the test
and before the import ensures that pytest skips the test in
case fpdf is not installed.
Closes #2408
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2419 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 49 49
Lines 8007 8007
Branches 1616 1616
=======================================
Hits 7561 7561
Misses 276 276
Partials 170 170 ☔ View full report in Codecov by Sentry. |
MartinThoma
added a commit
that referenced
this pull request
Jan 28, 2024
## What's new ### Bug Fixes (BUG) - layout mode text extraction ZeroDivisionError (#2417) by @shartzog ### Testing (TST) - Skip tests using fpdf2 if it\'s not installed (#2419) by @MartinThoma [Full Changelog](4.0.0...4.0.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Debian ecosystem installs only packages which are also present in the Debian ecosystem for testing. This includes pytest, but it does not include fpdf2.
Adding the line 'pytest.importorskip("fpdf")' within the test and before the import ensures that pytest skips the test in case fpdf is not installed.
Closes #2408