MAINT: Update upload-artifact and download-artifact actions from v3 to v4#2352
Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom Dec 20, 2023
Merged
MAINT: Update upload-artifact and download-artifact actions from v3 to v4#2352MartinThoma merged 1 commit intopy-pdf:mainfrom
MartinThoma merged 1 commit intopy-pdf:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2352 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 43 43
Lines 7564 7564
Branches 1491 1491
=======================================
Hits 7146 7146
Misses 259 259
Partials 159 159 ☔ View full report in Codecov by Sentry. |
Member
|
Good work 👍 Thank you for fixing this issue 🙏 |
MartinThoma
added a commit
that referenced
this pull request
Dec 24, 2023
## What's new ### Bug Fixes (BUG) - Handle IndirectObject as image filter (#2355) by @stefan6419846 ### Documentation (DOC) - Quote specs in generate_file_identifiers (#2363) by @exiledkingcc - Notes about form fields and annotations (#1945) by @dmjohnsson23 - Notes about update_page_form_field_values(auto_regenerate) (#2359) by @dmjohnsson23 - Fix stamping example (#2358) by @dmjohnsson23 - Stamp images directly on a PDF (#2357) by @dmjohnsson23 - Correct the example of adding highlight annotation (#2341) by @Tobeabellwether ### Maintenance (MAINT) - Update upload-artifact and download-artifact actions from v3 to v4 (#2352) by @stefan6419846 ### Testing (TST) - Add xfail test for #2336 (#2365) by @MartinThoma - Increase test coverage for flate handling of image mode 1 (#2339) by @stefan6419846 ### Code Style (STY) - File identifier generation restructuring (#2362) by @exiledkingcc - Add PdfWriter._ID attribute (#2361) by @exiledkingcc - Variable naming convention (#2360) by @MartinThoma [Full Changelog](3.17.3...3.17.4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a general fix which covers #2344, #2345 and #2350, including some incompatible changes as detailed in #2344 (comment).
The key point is that both actions have to be updated at the same time to avoid conflicts. Additionally, artifacts of the same name are not supported anymore, thus I decided to go the recommended route from https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact to include the matrix parameters inside the artifact names.