Skip to content

ROB: Out-of-bounds issue in handle_tj (text extraction)#2342

Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom
rgwood-rely:rgwood/2320_fix_index_out_of_bounds_in_handle_tj
Dec 14, 2023
Merged

ROB: Out-of-bounds issue in handle_tj (text extraction)#2342
MartinThoma merged 1 commit intopy-pdf:mainfrom
rgwood-rely:rgwood/2320_fix_index_out_of_bounds_in_handle_tj

Conversation

@rgwood-rely
Copy link
Copy Markdown
Contributor

@rgwood-rely rgwood-rely commented Dec 13, 2023

Closes #2320

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38795f5) 94.27% compared to head (fb4ca1c) 94.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          43       43           
  Lines        7670     7670           
  Branches     1520     1520           
=======================================
  Hits         7231     7231           
  Misses        271      271           
  Partials      168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Copy Markdown
Collaborator

Please refer issue properly filled for review

@rgwood-rely
Copy link
Copy Markdown
Contributor Author

#2320

@stefan6419846
Copy link
Copy Markdown
Collaborator

You probably want to adjust your title to match https://pypdf.readthedocs.io/en/latest/dev/intro.html#commit-messages and a more meaningful message like in your branch name.

@pubpub-zz
Copy link
Copy Markdown
Collaborator

#2320

also if you add "closes #2320" in the first post, it will close automatically the issue when merging

@MartinThoma MartinThoma changed the title fixed OOB BUG: Out-of-bounds issue in handle_tj (text extraction) Dec 14, 2023
@MartinThoma MartinThoma changed the title BUG: Out-of-bounds issue in handle_tj (text extraction) ROB: Out-of-bounds issue in handle_tj (text extraction) Dec 14, 2023
@MartinThoma MartinThoma merged commit 40bc577 into py-pdf:main Dec 14, 2023
@MartinThoma
Copy link
Copy Markdown
Member

@rgwood-rely Thank you for your contribution @rgwood-rely 🙏

If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html

@MartinThoma
Copy link
Copy Markdown
Member

The fix will be released on Sunday :-)

MartinThoma added a commit that referenced this pull request Dec 17, 2023
## What's new

### Robustness (ROB)
-  Out-of-bounds issue in handle_tj (text extraction) (#2342) by @rgwood-rely

### Developer Experience (DEV)
-  Make make_release.py easier to configure (#2348) by @MartinThoma

### Maintenance (MAINT)
-  Bump actions/download-artifact from 3 to 4 (#2344) by @dependabot[bot]

[Full Changelog](3.17.2...3.17.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

index out of bounds in pypdf._text_extraction.handle_tj

4 participants