BUG: Error when filling a value with parentheses #2268#2269
Merged
MartinThoma merged 2 commits intopy-pdf:mainfrom Oct 28, 2023
Merged
BUG: Error when filling a value with parentheses #2268#2269MartinThoma merged 2 commits intopy-pdf:mainfrom
MartinThoma merged 2 commits intopy-pdf:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 43 43
Lines 7634 7635 +1
Branches 1506 1506
=======================================
+ Hits 7210 7211 +1
Misses 262 262
Partials 162 162
☔ View full report in Codecov by Sentry. |
pubpub-zz
requested changes
Oct 25, 2023
Collaborator
pubpub-zz
left a comment
There was a problem hiding this comment.
thanks for your contribution.
2 comments to complete your work
Contributor
Author
|
I've considered your feedback |
pubpub-zz
approved these changes
Oct 26, 2023
Collaborator
|
Shouldn't we add a test for this as well, at least at a basic level? |
Collaborator
I've thought about it but the only way is a visual check 🫤. If the test consist in checking replace is working I don't think it worth it |
Member
|
Thank you for your contribution @KanorUbu 🙏 If you want, I'll add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html |
Member
|
And thanks @pubpub-zz / @stefan6419846 for the review :-) |
MartinThoma
added a commit
that referenced
this pull request
Oct 29, 2023
## What's new ### Security (SEC) - Infinite recursion when using PdfWriter(clone_from=reader) (#2264) by @Alexhuszagh ### New Features (ENH) - Add parameter to select images to be removed (#2214) by @pubpub-zz ### Bug Fixes (BUG) - Correctly handle image mode 1 with FlateDecode (#2249) by @stefan6419846 - Error when filling a value with parentheses #2268 (#2269) by @KanorUbu - Handle empty root outline (#2239) by @pubpub-zz ### Documentation (DOC) - Improve merging docs (#2247) by @stefan6419846 ### Developer Experience (DEV) - Test Python 3.7 with cryptopgraphy provider as well (#2276) by @stefan6419846 - Run CI with windows-latest (#2258) by @MartinThoma - Use pytest-xdist (#2254) by @MartinThoma - Attribute correct authors in the release notes (#2246) by @stefan6419846 ### Maintenance (MAINT) - Apply pre-commit hooks (#2277) by @MartinThoma - Update requirements + mypy fixes (#2275) by @MartinThoma - Explicitly provide Any for IO generic argument (#2272) by @nilehmann ### Testing (TST) - Fix test_image_without_pillow in windows environment (#2257) by @pubpub-zz ### Code Style (STY) - Remove unused import by @MartinThoma [Full Changelog](3.16.4...3.17.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2268