Skip to content

ROB: XYZ destination to cope with missing left and top param#2237

Merged
MartinThoma merged 2 commits intopy-pdf:mainfrom
pubpub-zz:iss2236
Oct 7, 2023
Merged

ROB: XYZ destination to cope with missing left and top param#2237
MartinThoma merged 2 commits intopy-pdf:mainfrom
pubpub-zz:iss2236

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

closes #2236

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (30db3ef) 94.36% compared to head (73a3134) 94.33%.

❗ Current head 73a3134 differs from pull request most recent head d9d0d0f. Consider uploading reports for the commit d9d0d0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   94.36%   94.33%   -0.03%     
==========================================
  Files          43       43              
  Lines        7591     7595       +4     
  Branches     1498     1500       +2     
==========================================
+ Hits         7163     7165       +2     
- Misses        264      265       +1     
- Partials      164      165       +1     
Files Coverage Δ
pypdf/generic/_data_structures.py 91.67% <50.00%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

@MartinThoma all yours

@MartinThoma MartinThoma merged commit 4b090ba into py-pdf:main Oct 7, 2023
@MartinThoma
Copy link
Copy Markdown
Member

Thanks :-)

MartinThoma added a commit that referenced this pull request Oct 8, 2023
## What's new

### Bug Fixes (BUG)
-  invalid cm/tm in visitor functions (#2206) by @pubpub-zz
-  Encrypt / decrypt Stream object dictionaries (#2228) by @pilotandy
-  Support nested color spaces for the /DeviceN color space (#2241) by @Stefan
-  images property fails if NullObject in list (#2215) by @pubpub-zz

### Robustness (ROB)
-  XYZ destination to cope with missing left and top param (#2237) by @pubpub-zz

### Documentation (DOC)
-  Add pilotandy for #2228 as a contributor by @MartinThoma
-  Link to CONTRIBUTING.md in README.md (#2232) by @markpfeifle
-  Changelog by @MartinThoma

### Developer Experience (DEV)
-  Exclude tests from mypy checks by @MartinThoma
-  Unify mypy options and warn redundant workarounds (#2223) by @exiledkingcc
-  Stabilize Pillow test with Pillow missing (#2229) by @Stefan

### Maintenance (MAINT)
-  Update pinned packages (#2243) by @MartinThoma

### Testing (TST)
-  Regression test against non-deterministic accidental object reuse (#2244) by @MartinThoma

[Full Changelog](3.16.2...3.16.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to deal with errors in the bookmark structure

2 participants