DEV: Add upper limits for complexity#2108
Merged
MartinThoma merged 2 commits intopy-pdf:mainfrom Aug 24, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2108 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 41 41
Lines 7387 7387
Branches 1460 1460
=======================================
Hits 6954 6954
Misses 269 269
Partials 164 164
☔ View full report in Codecov by Sentry. |
Member
|
I agree that we should gradually converge to a codebase that is easier to read/understand, maintain, and extend. Thank you 🤗 |
Member
|
If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-) |
cclauss
added a commit
to cclauss/pypdf
that referenced
this pull request
Aug 25, 2023
MartinThoma
pushed a commit
that referenced
this pull request
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we set upper limits then if someone wants to contribute more complex code then they need to justify in their pull request why they need messier code than is already in the codebase.