Skip to content

BUG: append() fails when articles do not have /T#2080

Merged
MartinThoma merged 2 commits intopy-pdf:mainfrom
pubpub-zz:iss2078a
Aug 12, 2023
Merged

BUG: append() fails when articles do not have /T#2080
MartinThoma merged 2 commits intopy-pdf:mainfrom
pubpub-zz:iss2078a

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

@pubpub-zz pubpub-zz commented Aug 10, 2023

closes #2078
/T is optional

@pubpub-zz pubpub-zz changed the title Iss2078a BUG: append() fails when articles do not have /T Aug 10, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f0781db) 94.24% compared to head (a348d37) 94.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2080   +/-   ##
=======================================
  Coverage   94.24%   94.25%           
=======================================
  Files          41       41           
  Lines        7355     7358    +3     
  Branches     1448     1449    +1     
=======================================
+ Hits         6932     6935    +3     
  Misses        263      263           
  Partials      160      160           
Files Changed Coverage Δ
pypdf/_writer.py 88.18% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

@MartinThoma
All yours

@MartinThoma MartinThoma merged commit f70dfad into py-pdf:main Aug 12, 2023
@MartinThoma
Copy link
Copy Markdown
Member

Thank you 🙏

MartinThoma added a commit that referenced this pull request Aug 13, 2023
## What's new

### Performance Improvements (PI)
-  optimize _decode_png_prediction (#2068)

### Bug Fixes (BUG)
-  Fix incorrect tm_matrix in call to visitor_text (#2060)
-  Writing German characters into form fields (#2047)
-  Prevent stall when accessing image in corrupted pdf (#2081)
-  append() fails when articles do not have /T (#2080)

### Robustness (ROB)
-  Cope with xref not followed by separator (#2083)

[Full Changelog](3.15.0...3.15.1)
@pubpub-zz pubpub-zz deleted the iss2078a branch August 9, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError: '/T'

2 participants