BUG: Added check for field /Info when cloning reader document#2055
BUG: Added check for field /Info when cloning reader document#2055MartinThoma merged 2 commits intopy-pdf:mainfrom mnmtz:main
Conversation
Added check for optional field /Info in document root when cloning reader document. (Fixes issue #2049)
|
Could you please add a corresponding test case as well? |
|
@mnmtz |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2055 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 41 41
Lines 7332 7333 +1
Branches 1441 1442 +1
=======================================
+ Hits 6905 6906 +1
Misses 266 266
Partials 161 161
☔ View full report in Codecov by Sentry. |
|
Thank you for your contribution @mnmtz :-) If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-) |
|
I've labeled this with "BUG", because from the users perspective it fixed something that was wrong. This is mainly relevant for where to put it in the CHANGELOG. I doubt any user would get excited about this change, although it's an important improvement. ENH (enhancements, new features) are typically things that were not supported beforehand and expand the capabilities of pypdf. There are many edge cases. For example, @pubpub-zz recently improved the image support. There I decided to go with ENH, because it were bigger changes |
### New Features (ENH) - Add `level` parameter to compress_content_streams (#2044) - Process /uniHHHH for text_extract (#2043) ### Bug Fixes (BUG) - Fix AnnotationBuilder.link (#2066) - JPX image without ColorSpace (#2062) - Added check for field /Info when cloning reader document (#2055) - Fix indexed/CMYK images (#2039) ### Maintenance (MAINT) - Cryptography as primary dependency (#2053) [Full Changelog](3.14.0...3.15.0)
Added check for optional field /Info in document root when cloning reader document. (Fixes issue #2049)