Skip to content

ROB: Cope with garbage collector during cloning#1841

Merged
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss1788
Jul 29, 2023
Merged

ROB: Cope with garbage collector during cloning#1841
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss1788

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

fixes #1788

@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c2a741e) 93.87% compared to head (305f0b8) 93.88%.

❗ Current head 305f0b8 differs from pull request most recent head 7dc7310. Consider uploading reports for the commit 7dc7310 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1841   +/-   ##
=======================================
  Coverage   93.87%   93.88%           
=======================================
  Files          33       33           
  Lines        7009     7010    +1     
  Branches     1394     1394           
=======================================
+ Hits         6580     6581    +1     
  Misses        276      276           
  Partials      153      153           
Impacted Files Coverage Δ
pypdf/generic/_base.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

+1

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

oups forgot to say all Yours!🤣

@MartinThoma
Copy link
Copy Markdown
Member

I'm still uncertain about the -10. It's just so random. I don't understand where that comes from / what effect this change has.

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

if you prefer another magic number, I have no preference.

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

you may prefer this proposal🙂🙂

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

+1?

@MartinThoma MartinThoma changed the title ROB : cope with garbage collector during cloning ROB: Cope with garbage collector during cloning Jul 29, 2023
@MartinThoma MartinThoma merged commit 8188553 into py-pdf:main Jul 29, 2023
@MartinThoma
Copy link
Copy Markdown
Member

@pubpub-zz I've decided to simply trust you on this one 😄 I don't understand what this does / how this is fixing the issue, but you have proven to know a lot about pypdf + PDF specs. Hence I feel comfortable with merging it 🤗

MartinThoma added a commit that referenced this pull request Jul 29, 2023
## What's new

### New Features (ENH)
-  Accelerate image list keys generation (#2014)
-  Use `cryptography` for encryption/decryption as a fallback for PyCryptodome (#2000)
-  Extract LaTeX characters (#2016)
-  ASCIIHexDecode.decode now returns bytes instead of str (#1994)

### Bug Fixes (BUG)
-  Add RunLengthDecode filter (#2012)
-  Process /Separation ColorSpace (#2007)
-  Handle single element ColorSpace list (#2026)
-  Process lookup decoded as TextStringObjects (#2008)

### Robustness (ROB)
-  Cope with garbage collector during cloning (#1841)

### Maintenance (MAINT)
-  Cleanup of annotations (#1745)

[Full Changelog](3.13.0...3.14.0)
@pubpub-zz pubpub-zz deleted the iss1788 branch September 2, 2023 09:49
biredel added a commit to biredel/pypdf that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random bug with add_page

2 participants