Skip to content

BUG: 'DictionaryObject' object has no attribute 'indirect_reference'#1729

Merged
MartinThoma merged 2 commits intopy-pdf:mainfrom
pubpub-zz:iss1723
Mar 23, 2023
Merged

BUG: 'DictionaryObject' object has no attribute 'indirect_reference'#1729
MartinThoma merged 2 commits intopy-pdf:mainfrom
pubpub-zz:iss1723

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

@pubpub-zz pubpub-zz commented Mar 20, 2023

fixes #1728

@pubpub-zz pubpub-zz closed this Mar 20, 2023
@pubpub-zz pubpub-zz reopened this Mar 20, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (1e4086e) 92.49% compared to head (7f1c27d) 92.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   92.49%   92.53%   +0.03%     
==========================================
  Files          34       34              
  Lines        6533     6533              
  Branches     1292     1292              
==========================================
+ Hits         6043     6045       +2     
+ Misses        318      317       -1     
+ Partials      172      171       -1     
Impacted Files Coverage Δ
pypdf/_writer.py 86.19% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma
Copy link
Copy Markdown
Member

@pubpub-zz Could it be that you linked the wrong issue? I don't see how #1723 is related to this PR

@MartinThoma
Copy link
Copy Markdown
Member

Maybe #1728 ?

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

oups wrong copied from wrong tab...🙃

@MartinThoma MartinThoma changed the title BUG : fixes no attribute 'indirect_reference' error #1723 BUG: Fixes no attribute 'indirect_reference' error Mar 23, 2023
@MartinThoma MartinThoma added the is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF label Mar 23, 2023
@MartinThoma MartinThoma changed the title BUG: Fixes no attribute 'indirect_reference' error BUG: Fixes "'DictionaryObject' object has no attribute 'indirect_reference'" Mar 23, 2023
@MartinThoma MartinThoma changed the title BUG: Fixes "'DictionaryObject' object has no attribute 'indirect_reference'" BUG: 'DictionaryObject' object has no attribute 'indirect_reference' Mar 23, 2023
@MartinThoma MartinThoma merged commit 0331a7c into py-pdf:main Mar 23, 2023
MartinThoma added a commit that referenced this pull request Mar 26, 2023
Security (SEC):
-  Use Python's secrets module instead of random module (#1748)

New Features (ENH):
-  Add AnnotationBuilder.highlight text markup annotation (#1740)
-  Add AnnotationBuilder.popup (#1665)
-  Add AnnotationBuilder.polyline annotation support (#1726)
-  Add clone_from parameter in PdfWriter constructor (#1703)

Bug Fixes (BUG):
-  'DictionaryObject' object has no attribute 'indirect_reference' (#1729)

Robustness (ROB):
-  Handle params NullObject in decode_stream_data (#1738)

Documentation (DOC):
-  Project scope (#1743)

Maintenance (MAINT):
-  Add AnnotationFlag (#1746)
-  Add LazyDict.__str__ (#1727)

[Full Changelog](3.6.0...3.7.0)
@pubpub-zz pubpub-zz deleted the iss1723 branch June 24, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'DictionaryObject' object has no attribute 'indirect_reference'

2 participants