Skip to content

MAINT: compress the writer page, not the reader page#1708

Merged
MartinThoma merged 1 commit intomainfrom
benchmark-fix
Mar 12, 2023
Merged

MAINT: compress the writer page, not the reader page#1708
MartinThoma merged 1 commit intomainfrom
benchmark-fix

Conversation

@MartinThoma
Copy link
Copy Markdown
Member

See #1698

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6c4b20) 92.54% compared to head (0b44097) 92.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1708   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          34       34           
  Lines        6502     6502           
  Branches     1282     1282           
=======================================
  Hits         6017     6017           
  Misses        315      315           
  Partials      170      170           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma requested a review from pubpub-zz March 12, 2023 11:16
@MartinThoma
Copy link
Copy Markdown
Member Author

@pubpub-zz This should fix the pipeline. But I'm wondering if we might to create another release / if #1698 might break peoples workflows

@pubpub-zz
Copy link
Copy Markdown
Collaborator

The issue is that the PDF 1.7 states that the stream objects should be indirect object, and I've confirmed through the latests mods/tests that Acrobat is considering the file as invalid if the stream object is stored directly in the "/Contents" and not pointed through an IndirectObject (What I have observed is that pdf.js is tolerant and can display the object)
respecting this rule can not be done from a PdfReader.😔

@MartinThoma MartinThoma merged commit 19944fe into main Mar 12, 2023
@MartinThoma MartinThoma deleted the benchmark-fix branch March 12, 2023 13:46
MartinThoma added a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants