BUG: Switch from trimbox to cropbox when merging pages#1622
BUG: Switch from trimbox to cropbox when merging pages#1622MartinThoma merged 2 commits intomainfrom
Conversation
baed0cf to
2e90838
Compare
2e90838 to
42a61ce
Compare
Codecov ReportBase: 91.92% // Head: 91.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 33 33
Lines 6374 6375 +1
Branches 1272 1272
=======================================
+ Hits 5859 5860 +1
Misses 327 327
Partials 188 188
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I like your idea. 👏👏👏 PS : I would be interested in a quick merge in order to upgrade the remaining merges identified in #1615 |
|
@pubpub-zz Merged :-) Thanks for pointing out that MERGE_CROP_BOX should be in the docs 👍 And thanks for bringing up this topic multiple times 😄 |
Bug Fixes (BUG): - Switch from trimbox to cropbox when merging pages (#1622) - Text extraction not working with one glyph to char sequence (#1620) Robustness (ROB): - Fix 2 cases of "object has no attribute \'indirect_reference\'" (#1616) Testing (TST): - Add multiple retry on get_url for external PDF downloads (#1626) [Full Changelog](3.4.0...3.4.1)
@pubpub-zz Continuing our discussion from #879 and #1426 :-)
I'm not sure if exposing this that prominently is a good idea or if we should simply change it... but allowing people to easily switch back would potentially enable people to still get the old behavior if they need to
I also don't know if
MERGE_CROP_BOXis a good name for this attribute.