Skip to content

ROB: Cope with cmap from #1370#1372

Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom
pubpub-zz:iss1370
Sep 28, 2022
Merged

ROB: Cope with cmap from #1370#1372
MartinThoma merged 1 commit intopy-pdf:mainfrom
pubpub-zz:iss1370

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

@pubpub-zz pubpub-zz commented Sep 27, 2022

fixes #1370
cope with cmap where the range contains first and last code are on variable length.
Also fix cases where the code is on 3 characters only (not standard)
no test data available

fixes py-pdf#1322
cope with cmap where the range contains first and last   code are on variable length.
Also fix cases where the code is on 3 characters only (not standard)
no test data available
@pubpub-zz pubpub-zz changed the title FIX : cope with cmap from #1322 ROB : cope with cmap from #1322 Sep 27, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2022

Codecov Report

Base: 94.10% // Head: 94.10% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c216b97) compared to base (d9aa64c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files          28       28           
  Lines        5071     5072    +1     
  Branches     1052     1052           
=======================================
+ Hits         4772     4773    +1     
  Misses        177      177           
  Partials      122      122           
Impacted Files Coverage Δ
PyPDF2/_cmap.py 95.11% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma changed the title ROB : cope with cmap from #1322 ROB: Cope with cmap from #1322 Sep 28, 2022
@MartinThoma MartinThoma added the is-robustness-issue From a users perspective, this is about robustness label Sep 28, 2022
@MartinThoma MartinThoma merged commit f3b6d0e into py-pdf:main Sep 28, 2022
@pubpub-zz pubpub-zz changed the title ROB: Cope with cmap from #1322 ROB: Cope with cmap from #1370 Sep 28, 2022
MartinThoma added a commit that referenced this pull request Oct 10, 2022
Bug Fixes (BUG):
- td matrix (#1373)
- Cope with cmap from #1322 (#1372)

Robustness (ROB):
-  Cope with str returned from get_data in cmap (#1380)

Full Changelog: 2.11.0...2.11.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is-robustness-issue From a users perspective, this is about robustness

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled Exception in the library crashes code binascii.Error: Odd-length string

2 participants