ROB: Fix merge_page for pages without resources#1349
Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom Sep 17, 2022
Merged
Conversation
Codecov ReportBase: 94.63% // Head: 94.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
+ Coverage 94.63% 94.67% +0.04%
==========================================
Files 30 30
Lines 5140 5146 +6
Branches 1058 1058
==========================================
+ Hits 4864 4872 +8
Misses 164 164
+ Partials 112 110 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
Amazing - you could close one of the oldest issues left 🎉 |
MartinThoma
added a commit
that referenced
this pull request
Sep 18, 2022
New Features (ENH): - Add rotation property and transfer_rotate_to_content (#1348) Performance Improvements (PI): - Avoid string concatenation with large embedded base64-encoded images (#1350) Bug Fixes (BUG): - Format floats using their intrinsic decimal precision (#1267) Robustness (ROB): - Fix merge_page for pages without resources (#1349) Full Changelog: 2.10.8...2.10.9
samuelhwilliams
added a commit
to alphagov/notifications-template-preview
that referenced
this pull request
Oct 26, 2022
We've been seeing quite a few KeyError `/Resources` errors lately. This can happen when pages don't have a `/Resources` key - but in PDFs missing resources can be inferred from previous pages. This issue was raised py-pdf/pypdf#1349 and fixed in v2.10.9. Bumping to this version will stop the app throwing 500s and instead either complete successfully or return the correct validation error, which should prevent some users contacting support. Add a test for PyPDF2 KeyError /Resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #270