Modify CI to better verify built package contents#1244
Merged
MartinThoma merged 3 commits intomainfrom Aug 17, 2022
Merged
Conversation
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
4893782 to
626d936
Compare
Codecov Report
@@ Coverage Diff @@
## main #1244 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 30 30
Lines 4979 4979
Branches 1025 1025
=======================================
Hits 4709 4709
Misses 153 153
Partials 117 117 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Wow, this is amazing work @MasterOdin 😍 Thank you so much 🤗 This is a great improvement - especially if/when I hand over the maintainer role at some point to ensure that others don't make the same mistake (I hope I have learned it now 😅 🙈 🤞 ) |
MartinThoma
added a commit
that referenced
this pull request
Aug 21, 2022
Robustness (ROB): - Decrypt returns empty bytestring (#1258) Documentation (DOC): - Adding WevertonGomes as a Contributor Developer Experience (DEV): - Modify CI to better verify built package contents (#1244) Maintenance (MAINT): - Remove unused sign function in _extract_text (#1262) - Remove \'mine\' as PdfMerger always creates the stream (#1261) - Let PdfMerger._create_stream raise NotImplemented (#1251) - password param of _security._alg32(...) is only a string, not bytes (#1259) - Remove unreachable code in read_block_backwards (#1250) Testing (TST): - Delete annotations (#1263) - Close PdfMerger in tests (#1260) - PdfReader.xmp_metadata workflow (#1257) - Various PdfWriter (Layout, Bookmark deprecation) (#1249) Full Changelog: 2.10.2...2.10.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR modifies the package CI job in two ways:
packagetocheck-wheel-contents(see action failure example). This makes it so thatcheck-wheel-contentsverifies that each file in the package are actually in the wheel following their directory structure.Either of these steps would have been sufficient to have caught #1242 per the example runs above.