MAINT: Introduce WrongPasswordError / FileNotDecryptedError / EmptyFileError#1201
Merged
MartinThoma merged 5 commits intopy-pdf:mainfrom Aug 4, 2022
chilledgeek:clearer-exception-classes
Merged
MAINT: Introduce WrongPasswordError / FileNotDecryptedError / EmptyFileError#1201MartinThoma merged 5 commits intopy-pdf:mainfrom chilledgeek:clearer-exception-classes
MartinThoma merged 5 commits intopy-pdf:mainfrom
chilledgeek:clearer-exception-classes
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 92.14% 92.15%
=======================================
Files 24 24
Lines 4939 4945 +6
Branches 1021 1024 +3
=======================================
+ Hits 4551 4557 +6
Misses 244 244
Partials 144 144
Help us with your feedback. Take ten seconds to tell us how you rate us. |
MartinThoma
reviewed
Aug 4, 2022
Member
|
Makes sense to me! I'll review it after work (hopefully... It's crazy hot) |
MartinThoma
reviewed
Aug 4, 2022
MartinThoma
reviewed
Aug 4, 2022
MartinThoma
requested changes
Aug 4, 2022
Member
MartinThoma
left a comment
There was a problem hiding this comment.
Thank you for this PR!
There are two minor comments in test_reader.py - besides that, it's good to go 🎉
…PDF2 into clearer-exception-classes
Author
addressed. thanks |
Member
|
The PR is merged and will be part of the release on Sunday. Thank you 🤗 |
Member
|
If you want, I can add you to https://pypdf2.readthedocs.io/en/latest/meta/CONTRIBUTORS.html . Just let me know which line I should use: |
Author
Thank you @MartinThoma! I'll go with this: |
MartinThoma
added a commit
that referenced
this pull request
Aug 7, 2022
New Features (ENH): - "with" support for PdfMerger and PdfWriter (#1193) - Add AnnotationBuilder.text(...) to build text annotations (#1202) Bug Fixes (BUG): - Allow IndirectObjects as stream filters (#1211) Documentation (DOC): - Font scrambling - Page vs Content scaling (#1208) - Example for orientation parameter of extract_text (#1206) - Fix AnnotationBuilder parameter formatting (#1204) Developer Experience (DEV): - Add flake8-print (#1203) Maintenance (MAINT): - Introduce WrongPasswordError / FileNotDecryptedError / EmptyFileError (#1201) Full Changelog: 2.9.0...2.10.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1200
Story:
PdfReadError: