BUG : Named Dest in PDF1.1(#1173)#1174
Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom Jul 27, 2022
Merged
Conversation
Named dest are stored in a dictionnary in PDF 1.1 TODO : a test for named destination stored in name tree should be added to improve coverage
Codecov Report
@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
- Coverage 92.29% 92.27% -0.02%
==========================================
Files 24 24
Lines 4813 4818 +5
Branches 991 993 +2
==========================================
+ Hits 4442 4446 +4
Misses 230 230
- Partials 141 142 +1
Continue to review full report at Codecov.
|
Member
|
@pubpub-zz Should I wait or merge? |
Collaborator
Author
|
ready to be merged. Can not find a test file for the TODO |
MartinThoma
added a commit
that referenced
this pull request
Jul 31, 2022
New Features (ENH): - Add ability to add hex encoded colors to outline items (#1186) - Add support for pathlib.Path in PdfMerger.merge (#1190) - Add link annotation (#1189) - Add capability to filter text extraction by orientation (#1175) Bug Fixes (BUG): - Named Dest in PDF1.1 (#1174) - Incomplete Graphic State save/restore (#1172) Documentation (DOC): - Update changelog url in package metadata (#1180) - Table extraction (#1179) - Mention pyHanko for signing PDF documents (#1178) - We now have CMAP support (#1177) Maintenance (MAINT): - Consistant usage of warnings / log messages (#1164) - Consistent terminology for outline items (#1156) Code Style (STY): - Apply pre-commit (#1188) Full Changelog: 2.8.1...2.9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named dest are stored in a dictionnary in PDF 1.1
TODO : a test for named destination stored in name tree should be added to improve coverage
[#1173)