BUG: Add missing deprecated EncodedStreamObject functions#1140
BUG: Add missing deprecated EncodedStreamObject functions#1140MartinThoma merged 1 commit into1.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #1140 +/- ##
==========================================
- Coverage 77.25% 77.19% -0.06%
==========================================
Files 17 17
Lines 4393 4399 +6
Branches 820 820
==========================================
+ Hits 3394 3396 +2
- Misses 818 822 +4
Partials 181 181
Continue to review full report at Codecov.
|
| self.decoded_self = decoded | ||
| return decoded._data | ||
|
|
||
| def getData(self): |
There was a problem hiding this comment.
The other deprecated functions in this file do not have the # pragma: no cover so I opted to not include it here like I did in #1139 (where all deprecated functions do have the pragma). Wasn't sure if should include it (and so that would probably get codecov to pass) or not include it.
|
oooh, very nice! Thank you for creating this branch - ok, then I'll make the update for 1.x as well :-) |
BUG: Add missing deprecated EncodedStreamObject functions (#1140)
Backport of #1139 applied against 1.x. Please see that PR for any discussion / review.
Once merged and a new 1.x release, will fix the issue for #1138 preventing upgrading to latest 1.x release.