Skip to content

remove i_ref1#938

Merged
s3alfisc merged 6 commits intopy-econometrics:masterfrom
WiktorTheScriptor:master
Jun 15, 2025
Merged

remove i_ref1#938
s3alfisc merged 6 commits intopy-econometrics:masterfrom
WiktorTheScriptor:master

Conversation

@WiktorTheScriptor
Copy link
Copy Markdown
Contributor

@WiktorTheScriptor WiktorTheScriptor commented Jun 15, 2025

No description provided.

@WiktorTheScriptor
Copy link
Copy Markdown
Contributor Author

WiktorTheScriptor commented Jun 15, 2025

pre-commit.ci autofix

@s3alfisc
Copy link
Copy Markdown
Member

s3alfisc commented Jun 15, 2025

Looks excellent, thank you @WiktorTheScriptor 👍

@s3alfisc
Copy link
Copy Markdown
Member

s3alfisc commented Jun 15, 2025

Hi, I just merged a new PR into master that introduces a new function, quantreg. Could you please merge master into your dev branch and also delete the i_ref1 arg there? Sorry 😄 alternatively I can also do it myself in a separate PR.

@WiktorTheScriptor
Copy link
Copy Markdown
Contributor Author

WiktorTheScriptor commented Jun 15, 2025

sure, no problem

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
core-tests 78.40% <ø> (-0.01%) ⬇️
tests-extended ?
tests-vs-r 16.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/estimation.py 92.51% <ø> (+0.30%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@s3alfisc
Copy link
Copy Markdown
Member

s3alfisc commented Jun 15, 2025

Test suite fails - we still have to delete the deprecation error check:

pyfixest/tests/test_errors.py

Line 393 in 8619614

def test_deprecation_errors():

@WiktorTheScriptor
Copy link
Copy Markdown
Contributor Author

WiktorTheScriptor commented Jun 15, 2025

pre-commit.ci autofix

@WiktorTheScriptor
Copy link
Copy Markdown
Contributor Author

WiktorTheScriptor commented Jun 15, 2025

hmm. how do I see what is making these tests fail?

@s3alfisc
Copy link
Copy Markdown
Member

s3alfisc commented Jun 15, 2025

pre-commit.ci autofix

@s3alfisc
Copy link
Copy Markdown
Member

s3alfisc commented Jun 15, 2025

@all-contributors please add @WiktorTheScriptor for code

@allcontributors allcontributors bot mentioned this pull request Jun 15, 2025
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented Jun 15, 2025

@s3alfisc

I've put up a pull request to add @WiktorTheScriptor! 🎉

@s3alfisc
Copy link
Copy Markdown
Member

s3alfisc commented Jun 15, 2025

Merging now, thank you @WiktorTheScriptor !

@s3alfisc s3alfisc merged commit b0ff66e into py-econometrics:master Jun 15, 2025
9 checks passed
damandhaliwal pushed a commit to damandhaliwal/pyfixest that referenced this pull request Jun 17, 2025
@s3alfisc
Merge pull request py-econometrics#938 from WiktorTheScriptor/master
2a972aa 
remove i_ref1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s3alfisc s3alfisc s3alfisc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WiktorTheScriptor @s3alfisc