Prevent Casting Dependent Variable to Integer to Avoid Information Loss in Poisson Regression#900
Merged
s3alfisc merged 4 commits intopy-econometrics:masterfrom May 12, 2025
JaapCTJ:remove-casting-to-integer-in-fepois
Merged
Prevent Casting Dependent Variable to Integer to Avoid Information Loss in Poisson Regression#900s3alfisc merged 4 commits intopy-econometrics:masterfrom JaapCTJ:remove-casting-to-integer-in-fepois
s3alfisc merged 4 commits intopy-econometrics:masterfrom
JaapCTJ:remove-casting-to-integer-in-fepois
Conversation
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…ois' and resolve conflicts
Contributor
Author
|
Instead of removing the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
Looks good to me! Thank you Jaap @JaapCTJ |
Member
|
@all-contributors please add @JaapCTJ for code |
Contributor
|
I've put up a pull request to add @JaapCTJ! 🎉 |
damandhaliwal
pushed a commit
to damandhaliwal/pyfixest
that referenced
this pull request
Jun 17, 2025
…ss in Poisson Regression (py-econometrics#900)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the line of code in
fepois_.pythat converts the dependent variable Y to an integer. Poisson regression can be applied to any non-negative outcomes, and there is no need to limit its use to non-negative integer outcomes by converting float Y values into integers.This makes the results more consistent with the
Fixestpackage in R, where it does not perform this conversion either.Additionally, it might be nice to add a non-negative non-integer generated dependant variable in the
get_data()function inutils.py. This would demonstrate the versatility of Poisson regression beyond integer-only outcomes and provide users with a broader perspective on its application.