Skip to content

renaming categories without T. notation#886

Merged
s3alfisc merged 2 commits intopy-econometrics:masterfrom
FuZhiyu:fix-renaming-cat
Apr 29, 2025
Merged

renaming categories without T. notation#886
s3alfisc merged 2 commits intopy-econometrics:masterfrom
FuZhiyu:fix-renaming-cat

Conversation

@FuZhiyu
Copy link
Copy Markdown
Contributor

@FuZhiyu FuZhiyu commented Apr 29, 2025

Addresses #884. Simple fix by simply making 'T.' optional

Copy link
Copy Markdown
Member

@s3alfisc s3alfisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @FuZhiyu! In particular, thanks for adding tests, I completely forgot we set these up at some point 😄

@s3alfisc
Copy link
Copy Markdown
Member

@all-contributors please add @FuZhiyu for bug and code

@allcontributors
Copy link
Copy Markdown
Contributor

@s3alfisc

I've put up a pull request to add @FuZhiyu! 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
core-tests 80.35% <100.00%> (ø)
tests-extended ?
tests-vs-r 47.10% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/report/utils.py 97.61% <100.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@s3alfisc s3alfisc merged commit 463d742 into py-econometrics:master Apr 29, 2025
8 checks passed
damandhaliwal pushed a commit to damandhaliwal/pyfixest that referenced this pull request Jun 17, 2025
* renaming categories without T. notation

* trailing white space?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants