Skip to content

Conversation

@JordanMartinez
Copy link
Contributor

Description of the change

Fixes #4242

I've listed the changelog entry as 'internal' as I'm not quite sure how this is a "breaking change" to end-users. CI does build our binaries, so perhaps that can affect things?


Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@rhendric
Copy link
Member

Yeah, it's not a breaking change from a you-can-always-build-from-source perspective, but we seem to have a set of users who can't/won't do that, and for them, changing how the binaries get built can be breaking—at least on Linux, it motivated the whole conversation in #4107. I don't know if bumping the Windows build environment can have the same impact, but I tagged the issue as breaking thinking maybe better safe than sorry.

OTOH, @hdgarrood agreed with you on not marking this sort of thing as breaking in the changelog. I'm not convinced that policy best serves those aforementioned users, but given that this is a Windows-only change it's probably a moot point either way?

@JordanMartinez JordanMartinez mentioned this pull request Feb 27, 2022
5 tasks
@JordanMartinez
Copy link
Contributor Author

Perhaps it should be mentioned in the Discourse announcement for Windows users?

@JordanMartinez JordanMartinez merged commit 20d8441 into purescript:master Feb 27, 2022
@JordanMartinez JordanMartinez deleted the update-ci-windows branch February 27, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Windows CI runner from windows-2016 to windows-2019

2 participants