Skip to content

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Feb 22, 2022

Description of the change

Breaking changes that will be made in v0.15.x. Removes syntax that was deprecated in v0.14.x.

# Type was replaced with Row Type:

-- 0.13.x
data RProxy (rows :: # Type) = RProxy
-- 0.14.x
data RProxy (rows :: Row Type) = RProxy

kind declarations, imports, and exports no longer require use a keyword of 'kind'.

-- 0.13.x
module Foo (kind MyKind) where

import Bar (kind AnotherKind)

foreign import kind MyKind
foreign import data Foo :: MyKind
-- 0.14.x
module Foo (MyKind) where

import Bar (AnotherKind)

data MyKind
foreign import data Foo :: MyKind

Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

There are 18 shift-reduce conflicts. I'm not sure what's causing it, but attached is the info file produced by Happy.
grammar-info.txt

@JordanMartinez
Copy link
Contributor Author

To clarify, should the warnings be updated to errors? Or are they removed completely as I've done in this PR?

@rhendric rhendric added this to the v0.15.0 milestone Feb 22, 2022
JordanMartinez and others added 2 commits February 22, 2022 15:46
Co-authored-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu>
@JordanMartinez JordanMartinez mentioned this pull request Feb 27, 2022
5 tasks
@JordanMartinez JordanMartinez merged commit 4c4fcf6 into purescript:master Feb 27, 2022
@JordanMartinez JordanMartinez deleted the address-deprecations branch February 27, 2022 02:01
@JordanMartinez JordanMartinez mentioned this pull request Feb 28, 2022
5 tasks
Neppord added a commit to intellij-purescript/intellij-purescript that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants