Print proxy type as an operator #3124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paf31
reviewed
Oct 21, 2017
| proxyType :: Pattern () Type (Type, Type) | ||
| proxyType = mkPattern match | ||
| where | ||
| match (ProxyType t) = Just (TypeConstructor (Qualified Nothing (ProperName "@")), t) |
Contributor
There was a problem hiding this comment.
I'm wondering if we should add Prefix to pattern-arrows going forward, but I'm fine with this in the meantime. Could you please add a comment though?
paf31
approved these changes
Oct 21, 2017
Member
Author
|
Rebased and commented. Let me know if you want it to say something else. |
Contributor
|
👍 Sounds good, thanks! |
hdgarrood
added a commit
that referenced
this pull request
Dec 30, 2017
This reverts commit cfd1db3.
Merged
hdgarrood
added a commit
that referenced
this pull request
Jan 3, 2018
* Revert "pretty print proxy types when rendering docs (#3144)" This reverts commit 14227c7. * Revert "Print proxy type as an operator (#3124)" This reverts commit cfd1db3. * Revert "Fix proxies: synonyms, inference, traversals, instances (#3095)" This reverts commit fe0aa0d. * Revert "Add proxies (#2846)" This reverts commit 74bc4a9. * Remove one last occurrence of the ProxyType constructor * Update tests to not use new proxies
matthewleon
pushed a commit
to matthewleon/purescript
that referenced
this pull request
Jan 6, 2018
* Revert "pretty print proxy types when rendering docs (purescript#3144)" This reverts commit 14227c7. * Revert "Print proxy type as an operator (purescript#3124)" This reverts commit cfd1db3. * Revert "Fix proxies: synonyms, inference, traversals, instances (purescript#3095)" This reverts commit fe0aa0d. * Revert "Add proxies (purescript#2846)" This reverts commit 74bc4a9. * Remove one last occurrence of the ProxyType constructor * Update tests to not use new proxies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3076
Example input:
Output:
I originally also changed the parser so it treated
@as a prefix type operator that binds tighter than type application, but this caused problems with instances because@Intisn't a type-atom. E.g:instance foo :: Foo @twould have to have been written asinstance foo :: Foo (@t). So I reverted this.