Skip to content

Run AppendSymbol in reverse #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paf31 merged 1 commit into from
Aug 5, 2017
Merged

Run AppendSymbol in reverse #3025

paf31 merged 1 commit into from
Aug 5, 2017

Conversation

@paf31
Copy link
Contributor

@paf31 paf31 commented Aug 5, 2017 •
edited
Loading

Should be merged with purescript/purescript-typelevel-prelude#19

We can run AppendSymbol in reverse, stripping a prefix or suffix from a type level string.

This lets us write simple parsers at the type level, which might lead to some interesting applications.

@LiamGoodacre Could you please review this?

LiamGoodacre
LiamGoodacre approved these changes Aug 5, 2017
View reviewed changes
Copy link
Member

@LiamGoodacre LiamGoodacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooooooh. Looks great!

@paf31 paf31 merged commit cb1393c into master Aug 5, 2017
@paf31 paf31 deleted the phil/append-in-reverse branch August 5, 2017 23:59
@paf31
Copy link
Contributor Author

paf31 commented Aug 5, 2017

Thanks!

@paf31
Copy link
Contributor Author

paf31 commented Aug 6, 2017

Oops, I just realized we need a breaking change to typelevel-prelude for this.

What do people think? Should I revert this, or shall we just merge in the things for 0.12.0 and make that release now?

@hdgarrood
Copy link
Contributor

hdgarrood commented Aug 6, 2017

I'm happy either way. Were there any other breaking changes we want to do soonish?

@paf31
Copy link
Contributor Author

paf31 commented Aug 6, 2017

Constraint kinds was the only one, and I think I have a plan to implement something which is non-breaking instead.

@paf31
Copy link
Contributor Author

paf31 commented Aug 6, 2017

Note to self: I also need to fix the tag for typelevel-prelude for the tests.

@garyb
Copy link
Member

garyb commented Aug 6, 2017 •
edited
Loading

I guess we can release 0.11.7 from a branch then, and maybe not merge much else into master until that is done? 😛

I'm hoping to have expr source annotations done today, but it's hard to tell since the errors come in an endless stream rather than being able to tell all at once.

paf31 added a commit that referenced this pull request Aug 6, 2017
@paf31
Revert "Run AppendSymbol in reverse (#3025)"
8df0a69 
This reverts commit cb1393c.
@paf31 paf31 mentioned this pull request Aug 6, 2017
Merged
paf31 added a commit that referenced this pull request Aug 6, 2017
@paf31
Revert "Run AppendSymbol in reverse (#3025)" (#3027)
59d1c6a 
This reverts commit cb1393c.
paf31 added a commit that referenced this pull request Aug 6, 2017
@paf31
Revert "Revert "Run AppendSymbol in reverse (#3025)" (#3027)"
3fd694f 
This reverts commit 59d1c6a.
@paf31 paf31 mentioned this pull request Aug 6, 2017
Merged
kritzcreek pushed a commit to kritzcreek/purescript that referenced this pull request Aug 6, 2017
@paf31 @kritzcreek
Run AppendSymbol in reverse (purescript#3025)
66f3b83
paf31 added a commit that referenced this pull request Sep 10, 2017
@paf31
Revert "Revert "Run AppendSymbol in reverse (#3025)" (#3027)" (#3030)
2a84878 
This reverts commit 59d1c6a.
@garyb garyb mentioned this pull request Apr 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiamGoodacre LiamGoodacre LiamGoodacre approved these changes

Assignees

No one assigned

Labels

status: ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paf31 @hdgarrood @garyb @LiamGoodacre