fix: support VIRTUAL_ENV_PROMPT alongside VIRTUAL_ENV#405
Merged
edouard-lopez merged 2 commits intopure-fish:masterfrom Feb 13, 2026
Merged
fix: support VIRTUAL_ENV_PROMPT alongside VIRTUAL_ENV#405edouard-lopez merged 2 commits intopure-fish:masterfrom
edouard-lopez merged 2 commits intopure-fish:masterfrom
Conversation
edouard-lopez
requested changes
Feb 12, 2026
Member
edouard-lopez
left a comment
There was a problem hiding this comment.
Great, thank!
Just a tiny change on the doc and we are good
Co-authored-by: Édouard Lopez <edouard-lopez@users.noreply.github.com>
edouard-lopez
approved these changes
Feb 13, 2026
Member
|
Failure is on the deployment of the doc as you don't have the permission to do so. see #406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: extends #195
In addition to the already implemented
VIRTUAL_ENVvariable, many Python virtual env tools also setVIRTUAL_ENV_PROMPT(e.g. virtualenv). UnlikeVIRTUAL_ENV, which is the absolute path to the virtual env directory (e.g./home/user/project/.venv),VIRTUAL_ENV_PROMPTis just the name of the virtual env project.This pull request implements displaying
VIRTUAL_ENV_PROMPTwhen it's set and defaulting to existingVIRTUAL_ENVorCONDA_DEFAULT_ENVbase names otherwise.Thanks for maintaining this project!
How to test pre-release?
Specs
Documentation
When
VIRTUAL_ENV_PROMPTandVIRTUAL_ENVare both set,VIRTUAL_ENV_PROMPTvalue is displayed. Otherwise, the order of precedence isVIRTUAL_ENVthenCONDA_DEFAULT_ENV.Acceptance Checks