Add test for virtualenvs created through conda#195
Merged
edouard-lopez merged 4 commits intopure-fish:masterfrom Dec 4, 2020
smsegal:conda_virtualenv
Merged
Add test for virtualenvs created through conda#195edouard-lopez merged 4 commits intopure-fish:masterfrom smsegal:conda_virtualenv
edouard-lopez merged 4 commits intopure-fish:masterfrom
smsegal:conda_virtualenv
Conversation
edouard-lopez
requested changes
Nov 15, 2020
Member
edouard-lopez
left a comment
There was a problem hiding this comment.
Hi @smsegal, thanks for the PRs!
Could you had a test based on the one for VIRTUAL_ENV in tests/_pure_prompt_virtualenv.test.fish?
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python Virtualenvs created through Anaconda are not currently detected in the pure prompt.
This simple addition to the virtualenv function fixes that and sets the virtualenv prompt correctly.