Skip to content

fix/360 fish title append an extra space in 4.0.2 (NixOS package)#365

Merged
edouard-lopez merged 2 commits intomasterfrom
fix/360-fish_title-append-an-extra-space-in-4-0-2
May 19, 2025
Merged

fix/360 fish title append an extra space in 4.0.2 (NixOS package)#365
edouard-lopez merged 2 commits intomasterfrom
fix/360-fish_title-append-an-extra-space-in-4-0-2

Conversation

@edouard-lopez
Copy link
Member

@edouard-lopez edouard-lopez commented May 19, 2025

fixes #360


  • test: add dependency to build-with-pure-source
  • fix(fish_title): use index to ignore extraneous item in status current-command

related: fixes #xxx

How to test pre-release?

☠️ Feature can be unstable and break your prompt!

fisher install pure-fish/pure@feat/foo_feature # branch name

First contribution?

Check the 👍 contributing guide for code and naming conventions.

Acceptance Checks

  • [ ] Documentation is up-to-date:
    • Add entry in feature list of README.md ;
    • Add entry in features' overview in docs/ ;
    • Add section in feature list to document
      • Features' flag ;
      • Prompt symbol ;
  • Default are defined in conf.d/pure.fish for:
    • Feature flag ;
    • Symbol ;
  • Tests are passing (I can help you 🤗 ):
  • [ ] Customization is available ;
  • [ ] Feature is implemented.

@edouard-lopez
Copy link
Member Author

I'm merging in order to allow the CI to bump version to start as it require tests container to pass (the one with 4.0.2 were blocking)

@edouard-lopez edouard-lopez merged commit 2577f30 into master May 19, 2025
5 of 6 checks passed
@edouard-lopez edouard-lopez deleted the fix/360-fish_title-append-an-extra-space-in-4-0-2 branch May 19, 2025 19:43
@edouard-lopez edouard-lopez changed the title fix/360 fish title append an extra space in 4 0 2 fix/360 fish title append an extra space in 4.0.2 (NixOS package) May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail due to fish_title appending an extra space in 4.0.2

1 participant