fish_title append an extra space in 4.0.2 #11503
Description
related: pure-fish/pure#360
Fish
❯ fish --version
fish, version 4.0.2
OSes
My CI execute tests for Fish 3.7.1 and 4.0.2 on
- MacOS
14.7.523H527 - NixOS
2.17.0 - Alpine
edge
Tests passes on Alpine with Fish 3.7.1 but failed on 4.0.2 with MacOS and NixOS
fish_title code
I do override the fish_title function but don't have a extra space
function fish_title \
--description "Set title to current folder and shell name" \
--argument-names last_command
set --local current_folder (fish_prompt_pwd_dir_length=$pure_shorten_window_title_current_directory_length prompt_pwd)
set --local current_command (status current-command 2>/dev/null; or echo $_)
set --local prompt "$current_folder: $last_command $pure_symbol_title_bar_separator $current_command"
if test -z "$last_command"
set prompt "$current_folder $pure_symbol_title_bar_separator $current_command"
end
echo $prompt
end
Failing test
Here is the test ran by fishtape that fails in 4.0.2 but not in 3.7.1
@test "fish_title: contains current directory and previous command" (
set --universal pure_symbol_title_bar_separator '-'
fish_title 'last-command'
) = "/tmp/current/directory: last-command - fish"
Test results
# /home/nemo/.config/fish/pure/tests/fish_title.test.fish
not ok 263 fish_title: contains current directory and previous command
---
operator: =
expected: '/tmp/current/directory: last-command - fish'
actual: '/tmp/current/directory: last-command - fish '
at: ~/.config/fish/pure/tests/fish_title.test.fish:13
...
Question
Did the fish_title function output change in 4.x?