Skip to content

Screenshots#132

Merged
edouard-lopez merged 6 commits intomasterfrom
screenshots
Jan 15, 2019
Merged

Screenshots#132
edouard-lopez merged 6 commits intomasterfrom
screenshots

Conversation

@edouard-lopez
Copy link
Member

@edouard-lopez edouard-lopez commented Jan 14, 2019

related: #113


I used shutter to take screenshots the content of the window then generated the window's decorations and shadow with Screely.

Pure with dark colorscheme Pure with light colorscheme

Build screenshot context

Colorscheme come from chriskempson/base16 thanks to smh/base16-shell-fish plugin. You can use whatever scheme name from the Scheme Repositories' section

Light

set colorscheme classic-light 
source ./tools/screenshots.fish 

Dark

set colorscheme classic-dark 
source ./tools/screenshots.fish 

Write command

I used the following

sleep 6s; false
cd $HOME/.dev/pure
git reset HEAD~1

Usage:

❯ set colorscheme classic-light
❯ source ./tools/screenshot.fish
❯ <commands-to-screenshot>
Copy link
Collaborator

@rafaelrinaldi rafaelrinaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the images look very bad on retina displays. I can try to take them on my computer to see if it looks better.

Will let you know.

@edouard-lopez
Copy link
Member Author

@rafaelrinaldi Sure, thanks :)

@edouard-lopez edouard-lopez added this to the v2.x-future milestone Jan 14, 2019
@edouard-lopez edouard-lopez added the 🚀 enhancement performance, UX or maintainability label Jan 14, 2019
@edouard-lopez
Copy link
Member Author

@rafaelrinaldi I pushed the unedited version of the screenshots if that can help.

@andreiborisov
Copy link
Collaborator

I used shutter to take screenshots the content of the window then generated the window's decorations and shadow with Screely.

I can take screenshots with Hyper on macOS. I mean I hate Hyper, but it looks pretty, you cannot deny that😏

@edouard-lopez
Copy link
Member Author

Whatever like best 👍

@andreiborisov
Copy link
Collaborator

andreiborisov commented Jan 15, 2019

@edouard-lopez since snazzy theme doesn't have light variation, I've used ayu mirage and ayu light themes.
screenshot 2019-01-15 at 18 09 36
screenshot 2019-01-15 at 18 12 03

@rafaelrinaldi
Copy link
Collaborator

Beautiful @schrodincat! It looks perfect on retina. I'm good with these.

@edouard-lopez
Copy link
Member Author

@schrodincat that is gorgeous!

How did you proceed?
What is retina's screen resolution?

@edouard-lopez
Copy link
Member Author

@rafaelrinaldi could you approve this PR, we require at least one (I though dismissing it would work.

Did you set new rules for PRs?

@andreiborisov
Copy link
Collaborator

andreiborisov commented Jan 15, 2019

How did you proceed?

@edouard-lopez I’ve used Hyper with hyper-ayu-light and hyper-ayu-mirage plugins. For some reason they had ugly 1px border, so I’ve edited plugins code and took screenshots with macOS built-in tool.

This is original ayu theme if you interested. It has been ported to pretty much every editor/terminal since then.

@edouard-lopez edouard-lopez changed the title WIP Screenshots Screenshots Jan 15, 2019
@edouard-lopez edouard-lopez merged commit 1fabe24 into master Jan 15, 2019
edouard-lopez added a commit that referenced this pull request Jan 15, 2019
@edouard-lopez edouard-lopez deleted the screenshots branch January 15, 2019 18:20
@andreiborisov
Copy link
Collaborator

andreiborisov commented Jan 15, 2019

What is retina's screen resolution?

@edouard-lopez you mean display? I'm on 5K iMac which is 5120 x 2880. I don't think it matters though, retina is just doubles pixels in both axis, so screenshots of the app taken on different retina Macs would look the same.

edouard-lopez added a commit that referenced this pull request Jan 8, 2021
edouard-lopez added a commit that referenced this pull request Jan 8, 2021
edouard-lopez added a commit that referenced this pull request Aug 21, 2023
edouard-lopez added a commit that referenced this pull request Aug 21, 2023
edouard-lopez added a commit that referenced this pull request May 20, 2025
Use the one from #132
edouard-lopez added a commit that referenced this pull request May 20, 2025
edouard-lopez added a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 enhancement performance, UX or maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants