Add test for presence of X-Forwarded-For and X-Forwarded-Proto HTTP headers #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66b3725 to
5125500
Compare
Contributor
Author
|
I managed to fix the issue by setting However, I am not very familiar with puma-dev codebase and golang. Please review if the fix is ok and let me know if any changes are required. |
nonrational
requested changes
Feb 1, 2022
Member
nonrational
left a comment
There was a problem hiding this comment.
Thanks for taking the time to find, test, and fix the issue!
Member
|
@vojtad can you update this branch to include the latest from |
…eaders Presence and content of `X-Forwarded-For` and `X-Forwarded-Proto` is checked in requests made to the origin server.
Generated cert is not trusted by the test runner.
4b3f265 to
0ecde59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presence and content of
X-Forwarded-ForandX-Forwarded-Protois checked in requests made to the origin server.X-Forwarded-Foris checked to be equal to127.0.0.1.X-Forwarded-Protois checked to be equal tohttpsbecause the test request is made using HTTPS.These headers are expected to be present when requests go through reverse proxy.
Especially
X-Forwarded-Protois required when proxy terminates SSL and forwards request to the origin server using plain HTTP. When this header is missing it can cause infinite redirect loop back to HTTPS.Checks for issue reported in #298 caused by #292. This test fails on
v0.18.0and passes onv0.17.0.