Upgrade to stdlib httputil #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prepare for the migration to the Go standard library's implementation of http.ReverseProxy, which no longer gives access to the raw http.ResponseWriter.
ded665a to
e2cb56b
Compare
Member
|
Thanks @cjlarose! 💯 Will merge along with some other fixes and cut a new release next week. |
Member
Author
|
Thanks @nonrational ! I actually have part 2 of this work ready-to-go soon (I removed the vendored |
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #290
This change replaces the use of the vendored
httputilpackage (which appears to be copied from an old version of the Go standard library) to the version of that package available from the modern standard library. It doesn't modify the usage of the other package mentioned in #290 (httpu).Manually, I tested the following features:
bogus.test)/publicfiles directly/statusand to/eventsfor the Hostpuma-dev