Skip to content

Add --insecure option to pulumi login#9159

Merged
bors[bot] merged 1 commit intomasterfrom
fraser/loginInsecure
Feb 4, 2023
Merged

Add --insecure option to pulumi login#9159
bors[bot] merged 1 commit intomasterfrom
fraser/loginInsecure

Conversation

@Frassle
Copy link
Copy Markdown
Member

@Frassle Frassle commented Mar 9, 2022

Description

Add --insecure option to pulumi login which disables https certificate checks.

Fixes #9120

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Copy Markdown
Contributor

pulumi-bot commented Feb 2, 2023

Changelog

[uncommitted] (2023-02-04)

Features

  • [cli] Add --insecure flag to pulumi login which disables https certificate checks
    #9159

Copy link
Copy Markdown
Contributor

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reasonable way to add test coverage for this?

Copy link
Copy Markdown
Contributor

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of force pushing a squashed commit to your branch that addresses my suggestions (fixes the bug, and removes the -k shorthand), and adds a changelog, to get it merged today. We can follow-up on adding test coverage.

Comment thread pkg/cmd/pulumi/login.go Outdated
Comment thread pkg/cmd/pulumi/login.go Outdated
@justinvp justinvp force-pushed the fraser/loginInsecure branch from b685a54 to aff451e Compare February 4, 2023 00:08
Add `--insecure` flag to `pulumi login` which disables https certificate checks
@justinvp justinvp force-pushed the fraser/loginInsecure branch from aff451e to 7d53b47 Compare February 4, 2023 00:09
Copy link
Copy Markdown
Contributor

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I force pushed a squashed commit w/ feedback addressed.

@justinvp
Copy link
Copy Markdown
Contributor

justinvp commented Feb 4, 2023

bors merge

bors Bot added a commit that referenced this pull request Feb 4, 2023
9159: Add --insecure option to `pulumi login` r=justinvp a=Frassle

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Add --insecure option to `pulumi login` which disables https certificate checks.

Fixes #9120

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have updated the [CHANGELOG-PENDING](https://github.com/pulumi/pulumi/blob/master/CHANGELOG_PENDING.md) file with my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


12001: Support clones from Azure DevOps r=RobbieMcKinstry a=squaremo

In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities _are_ supported, and expect them not to be used.

(See go-git/go-git#613 for more on this workaround.)

I tried this with a personal Azure DevOps account; an automated test would need either a reliably long-lived Azure DevOps repo, or a test server that can mimic Azure DevOps' particular capabilities. I'm open to suggestions!

12025: [sdks/go] Delegate alias computation to the engine r=abhinav a=Zaid-Ajaj

Fixes #11066
Addresses #11697 

Credit to `@abhinav` for making aliases unit-testable by intercepting `RegisterResource` calls. 

> I did change the test slightly so that it either checks for `AliasURNs: []string` or `Aliases: []*pulumirpc.Alias` because I've made it such that one of them is `nil` depending on `supportsAliasSpecs`

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [x] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Fraser Waters <fraser@pulumi.com>
Co-authored-by: Michael Bridgen <mbridgen@pulumi.com>
Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Feb 4, 2023

Build failed (retrying...):

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Feb 4, 2023

Build succeeded:

@bors bors Bot merged commit ef2fc9b into master Feb 4, 2023
@bors bors Bot deleted the fraser/loginInsecure branch February 4, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support self-signed certs for pulumi login

4 participants