fix capture groups for "each" statements#3274
Merged
ForbesLindesay merged 2 commits intopugjs:masterfrom Feb 28, 2021
Merged
Conversation
improve capture group regex for `each` statements using a greedy match. fixes pugjs#3263
pug-lexer (5.0.0 → 5.0.1)Bug Fixes
Packages With No ChangesThe following packages have no user facing changes, so won't be released:
|
add test cases covering pugjs#3275 and pugjs#3263
ForbesLindesay
approved these changes
Feb 28, 2021
This was referenced Mar 16, 2021
ngsctt
pushed a commit
to ngsctt/pug
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variables starting with
ofcause the regex to "drift" on capture groupsExample
This causes
Cause
The non-greedy
(.*)matches theofof the variable for theofstatement. This causes matching group misalignment, which leads to the displayed error.Workaround
Rename your variable to something not starting with
of😊fixes #3263
fixes #3275