Skip to content

test: add test to ensure that stub files are valid #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pthom merged 3 commits into from
Jun 3, 2025
Merged

test: add test to ensure that stub files are valid #351

pthom merged 3 commits into from
Jun 3, 2025

Conversation

@tlambert03
Copy link
Contributor

@tlambert03 tlambert03 commented May 27, 2025 •
edited
Loading

hey @pthom

this test might help to avoid regressions similar to #349

here's what it would have shown prior to #349

E           AssertionError: Found 1 .pyi files with syntax errors:
E
E           SyntaxError parsing implot/internal.pyi:
E           invalid syntax. Perhaps you forgot a comma? (internal.pyi, line 2241)

@pthom pthom merged commit 5221335 into pthom:main Jun 3, 2025
30 checks passed
@pthom
Copy link
Owner

pthom commented Jun 3, 2025

Hi @tlambert03

This is brilliant! It not only raises an error but show where it is located.
I just merged your PR.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tlambert03 @pthom