fix: exclude MkTime from implot_internal stubs
#349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, Thanks for the PR! |
Owner
|
You might have to discard some changes where ImTextureId was changed to ImTextureRef: these changes are for the incoming v1.92 of ImGui and were mistakenly merged to the generator options in the main branch. Manually discard this change: If too complex, I can run the generation on my side. Thanks! |
Contributor
Author
|
Not a problem, I did run it locally and saw those extra seemingly unrelated changes, so wanted to check first. Will submit later! |
Contributor
Author
|
ok, ready for another look @pthom 👍 |
pthom
approved these changes
May 25, 2025
Owner
|
Perfect, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #348
@pthom, this is the bare minimum (and can confirm it works to allow type checking externally again). Let me know if i should be generating and checking in the updated stubs as well (I supposed CI will likely tell me too)