Merged
Conversation
I think it was only PTB that was holding it back? Brad Larson fixed it on the PTB side in kleinerm/Psychtoolbox-3#276, and wheels with numpy 2 support were generated for 3.0.19.14 (https://github.com/aforren1/ptb-wheels/releases/tag/3.0.19.14).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7229 +/- ##
=======================================
Coverage 12.28% 12.28%
=======================================
Files 346 346
Lines 64066 64066
=======================================
Hits 7870 7870
Misses 56196 56196
🚀 New features to boost your workflow:
|
- `np.string_` was just an alias for `np.bytes_` - Getting a true/false value out of an empty array has been deprecated for awhile, and was removed in 2.0. AFAICT, checking if the value is a string should produce the same behavior?
mdcutone
pushed a commit
to mdcutone/psychopy
that referenced
this pull request
May 7, 2025
* PKG: Allow numpy>=2.0 I think it was only PTB that was holding it back? Brad Larson fixed it on the PTB side in kleinerm/Psychtoolbox-3#276, and wheels with numpy 2 support were generated for 3.0.19.14 (https://github.com/aforren1/ptb-wheels/releases/tag/3.0.19.14). * BF: Update some numpy usage to be compatible with v2. - `np.string_` was just an alias for `np.bytes_` - Getting a true/false value out of an empty array has been deprecated for awhile, and was removed in 2.0. AFAICT, checking if the value is a string should produce the same behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it was only PTB that was holding it back? Eric Larson fixed it on the PTB side in kleinerm/Psychtoolbox-3#276, and wheels with numpy 2 support were generated for 3.0.19.14 (https://github.com/aforren1/ptb-wheels/releases/tag/3.0.19.14).