Merged
Conversation
sotpapathe
added a commit
to sotpapathe/Super-Haxagon
that referenced
this pull request
Oct 1, 2025
TODO: Will become unnecessary once pspdev/pspsdk#330 is merged. This ensures that any de-initialization of the old Music object (e.g. de-registering callbacks) happens before initializing the new Music object. This is helpful for the upcoming PSP driver. TODO: Does this break other drivers? Use the blocking API instead if that's the case This will complicate the driver.
sotpapathe
added a commit
to sotpapathe/Super-Haxagon
that referenced
this pull request
Oct 10, 2025
TODO: Will become unnecessary once pspdev/pspsdk#330 is merged. This ensures that any de-initialization of the old Music object (e.g. de-registering callbacks) happens before initializing the new Music object. This is helpful for the upcoming PSP driver. TODO: Does this break other drivers? Use the blocking API instead if that's the case This will complicate the driver.
sharkwouter
approved these changes
Oct 12, 2025
Member
sharkwouter
left a comment
There was a problem hiding this comment.
This looks good, thanks! Sorry it took me a while to get to this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found no other way to get the currently set callback and its data so I implemented this. I also added the volume getter for completeness.