Support missing SNIMissingWarning in tests#6336
Merged
nateprewitt merged 2 commits intopsf:mainfrom Jan 21, 2023
Merged
Conversation
urllib3 2.0 only supports OpenSSL 1.1.1+ which means SNI is mandatory, and removed the warning altogether.
nateprewitt
approved these changes
Jan 20, 2023
Member
nateprewitt
left a comment
There was a problem hiding this comment.
Fair enough, this looks good. Thanks @pquentin!
Member
|
Looks like there's a small linting issue. Could you update the PR using our pre-commit hooks? Although where it's moving the test import doesn't look right to me 👀. I'll investigate that separately. |
Contributor
Author
|
Oops, sorry about that. Fixed the lint.
This is because I used |
abrBullyz
pushed a commit
to abrBullyz/requests
that referenced
this pull request
Feb 23, 2023
matthewarmand
pushed a commit
to matthewarmand/requests
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib3 2.0 only supports OpenSSL 1.1.1+ which means SNI is mandatory, and removed the warning altogether.