Use yield from instead of looping yield#6170
Merged
nateprewitt merged 1 commit intopsf:mainfrom Jun 29, 2022
kkirsche:patch-1
Merged
Use yield from instead of looping yield#6170nateprewitt merged 1 commit intopsf:mainfrom kkirsche:patch-1
nateprewitt merged 1 commit intopsf:mainfrom
kkirsche:patch-1
Conversation
This merge request updates the stream yield functionality to use `yield from` instead of `yield` within a for loop. Because this is yielding from an iterable, we can use `yield from` which is not only slightly shorter but also on average 15% more performant than using `yield` inside of a loop. This is a result of some of the optimizations included as part of [PEP 380](https://peps.python.org/pep-0380/)
nateprewitt
approved these changes
Jun 29, 2022
Member
nateprewitt
left a comment
There was a problem hiding this comment.
Let's do it, thanks @kkirsche!
Merged
Contributor
Author
|
Yep, part of splitting up #6165 to get past that...feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request updates the stream yield functionality to use
yield frominstead ofyieldwithin a for loop. Because this is yielding from an iterable, we can useyield fromwhich is not only slightly shorter but also on average 15% more performant than usingyieldinside of a loop. This is a result of some of the optimizations included as part of PEP 380