Fix # fmt: skip ignored in deeply nested expressions#4883
Merged
Conversation
180fecb to
49ae806
Compare
Collaborator
|
The diff-shades doesn't look right, it looks like some changes from Also, as a heads up, we're going to be releasing 25.12.0 over the weekend, and we want to keep 26.1.0 limited to purely stablizing preview styles as much as possible, so this probably won't get merged until after those are released. |
b2ab699 to
815b840
Compare
Contributor
Author
|
Thanks for the review. I’ve made the required changes. Happy to wait for the right window after the upcoming releases. |
Collaborator
|
Since this looks good and we haven't released yet, I'll go ahead and merge this now. Thanks! |
This was referenced Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4730
Black was ignoring
# fmt: skipin deeply nested expressions (e.g., multi-part if-clauses). This change updates the tree climbing logic to correctly find the start of the line and all relevant siblings, ensuring that# fmt: skipworks as intended even in complex nested cases.Checklist - did you ...
--previewstyle, following thestability policy?
CHANGES.mdif necessary?