Remove blank lines before class docstring#3692
Merged
JelleZijlstra merged 1 commit intopsf:mainfrom May 18, 2023
Merged
Conversation
|
diff-shades results comparing this PR (710c843) to main (db3668a). The full diff is available in the logs under the "Generate HTML diff report" step. |
JelleZijlstra
approved these changes
May 18, 2023
jsh9
added a commit
to jsh9/cercis
that referenced
this pull request
May 21, 2023
commit eedfc38 Author: Jason R. Coombs <jaraco@jaraco.com> Date: Fri May 19 13:00:29 2023 -0400 Avoid EncodingWarning in blib2to3 (psf#3696) commit 2fd9d8b Author: Jonathan Berthias <jvberthias@gmail.com> Date: Fri May 19 01:57:17 2023 +0200 Remove blank lines before class docstring (psf#3692) commit db3668a Author: Ray Bell <rayjohnbell0@gmail.com> Date: Tue May 16 22:47:45 2023 -0400 Sort DEFAULT_EXCLUDES and add .vscode, .pytest_cache and .ruff_cache (psf#3691) Co-authored-by: Ray Bell <ray.bell@dtn.com>
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3659
Since #3035, the blank lines between a function and its docstring are removed. The class docstring is special cased in the code to leave one blank line after, so that change has no effect. This PR fixes that.
BTW, I couldn't find a test for the function case so I added one just to be sure it doesn't regress :)
Checklist - did you ...
CHANGES.mdif necessary?