Prefer splitting right hand side of assignment statements.#3368
Merged
JelleZijlstra merged 10 commits intopsf:mainfrom Dec 15, 2022
Merged
Prefer splitting right hand side of assignment statements.#3368JelleZijlstra merged 10 commits intopsf:mainfrom
JelleZijlstra merged 10 commits intopsf:mainfrom
Conversation
|
diff-shades results comparing this PR (bcc8075) to main (a282181). The full diff is available in the logs under the "Generate HTML diff report" step. |
Contributor
Author
|
Looking at the diff-shades results, I need to fix the following isuses:
- (
- field,
- targets,
- alias,
- joins,
- path,
- opts,
- transform_function,
- ) = self._setup_joins(pieces, opts, alias)
+ (field, targets, alias, joins, path, opts, transform_function,) = (
+ self._setup_joins(pieces, opts, alias)
+ )
clone.external_aliases[alias] = (
- isinstance(table, Join)
- and table.join_field.related_model._meta.db_table != alias
- ) or (
- isinstance(table, BaseTable) and table.table_name != table.table_alias
+ (
+ isinstance(table, Join)
+ and table.join_field.related_model._meta.db_table != alias
+ )
+ or (
+ isinstance(table, BaseTable)
+ and table.table_name != table.table_alias
+ )
)
y_hat_discrete[
np.arange(y_hat_probas.shape[0]), y_hat_probas.argmax(axis=1)
- ] = 1
+ ] = (1) |
Collaborator
|
I was going to point out 1. but you beat me :) I don't think 2. is a problem: the parentheses around each |
Collaborator
|
I noticed this one: which I realize is another example of what you meant by 2. |
Collaborator
|
Also wanted to mention that most of the changes in diff-shades are clear improvements. This is going to be a positive change. |
Contributor
Author
|
Adding a note, looks like the handling of trailing comma on the left side is related to an existing issue: (
a,
b,
c,
d,
) = func1(arg1)
(a, b, c, d,) = func1(
arg1
) and func2(arg2)Maybe #1671? |
3 tasks
…erred. The logic is implemented in the _prefer_split_rhs_oop function.
Contributor
Author
|
The three issues mentioned above are now fixed, this is ready to review again. |
copybara-service bot
pushed a commit
to google/pyink
that referenced
this pull request
Dec 6, 2022
This Cherrypicks the changes from psf#3368 before this can be merged upstream. PiperOrigin-RevId: 493104368
Contributor
Author
|
Kindly ping? @JelleZijlstra |
JelleZijlstra
approved these changes
Dec 15, 2022
Collaborator
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looked over diff-shades again and everything looks good.
28 tasks
rgonzalezfluendo
added a commit
to fluendo/fluster
that referenced
this pull request
Feb 12, 2024
Adding skip fmt to avoid issues with black < 24. New rule added in black 24 is: > If an assignment statement is too long, we now prefer splitting on the right-hand side > psf/black#3368
rgonzalezfluendo
added a commit
to fluendo/fluster
that referenced
this pull request
Feb 12, 2024
Adding skip fmt to avoid issues with black < 24. New rule added in black 24 is: > If an assignment statement is too long, we now prefer splitting on the right-hand side > psf/black#3368
mdimopoulos
pushed a commit
to fluendo/fluster
that referenced
this pull request
Feb 15, 2024
Adding skip fmt to avoid issues with black < 24. New rule added in black 24 is: > If an assignment statement is too long, we now prefer splitting on the right-hand side > psf/black#3368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an assignment statement's left hand side fits on a single line, prefer splitting the right hand side's outer optional parens.
Fixes #1498.
Checklist - did you ...
CHANGES.mdif necessary?